Skip to content

Fre-cli container files#785

Open
Ciheim wants to merge 17 commits intoNOAA-GFDL:mainfrom
Ciheim:move-container-files
Open

Fre-cli container files#785
Ciheim wants to merge 17 commits intoNOAA-GFDL:mainfrom
Ciheim:move-container-files

Conversation

@Ciheim
Copy link
Copy Markdown
Contributor

@Ciheim Ciheim commented Mar 19, 2026

This pull request contains fre-cli container files being moved from the HPC-ME repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.15%. Comparing base (b73b470) to head (6578b68).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files          71       71           
  Lines        4955     4955           
=======================================
  Hits         4170     4170           
  Misses        785      785
Flag Coverage Δ
unittests 84.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73b470...6578b68. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@singhd789 singhd789 mentioned this pull request Mar 24, 2026
Closed
8 tasks
singhd789
singhd789 reviewed Mar 25, 2026
View reviewed changes
@Ciheim Ciheim marked this pull request as ready for review March 25, 2026 23:35
singhd789
singhd789 reviewed Mar 26, 2026
View reviewed changes
ceblanton
ceblanton requested changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but some still some ppp references in there.

How do we know if the pipeline works? Can we run the update_container_image action before we merge it?

@ilaflott ilaflott force-pushed the move-container-files branch from 72e35d0 to 9b4978f Compare March 30, 2026 15:19
@Ciheim
Copy link
Copy Markdown
Contributor Author

Ciheim commented Mar 31, 2026

Looking good but some still some ppp references in there.

How do we know if the pipeline works? Can we run the update_container_image action before we merge it?

I've removed the bad references. As far as testing, I'm not sure how much functionality I can verify before the merge. I've attempted to run the workflow by hand in both this repo and my fork and have been unable to do so.

ceblanton
ceblanton approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ciheim. It's ready for testing in the main branch. If there is something wrong we can adjust then.

ilaflott
ilaflott reviewed Mar 31, 2026
View reviewed changes
singhd789
singhd789 reviewed Mar 31, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilaflott ilaflott ilaflott left review comments

@singhd789 singhd789 singhd789 left review comments

@ceblanton ceblanton ceblanton approved these changes

Assignees

No one assigned

Labels

beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ciheim @ilaflott @ceblanton @singhd789